cool game but the math is broken on one time upgrades
Reviews for "Electrical Rubaroo"
Let's see.
You have several places where the game incorrectly sets things as equal to, when it should be a plus equals instead of a straight equals. (You're incorrectly making it do variable = value instead of the correct variable += value). This kills your battery capacity when buying some of those one-time upgrades, for example. Or if this isn't exactly what you're doing, you're still messing it up somehow -- all I know is buying some of those one-time upgrades LOWERS your max battery capacity when it definitely shouldn't!
You also have failure to check for >= in many cases, instead incorrectly checking for strict equality. Example -- I have a rubbing power less than 1 but greater than 0. I purchase the one-time upgrade that gives you a bonus one. Since it skips beyond 1, medal for having a rubbing power of 1 is not awarded when it should be, since I have a rubbing power of at least 1.
So to recap, when adding things to a variable, always do variable += value instead of variable = value. And when checking for equality conditions where the goal is a higher value, always do variable >= value instead of variable == value for the check. (Or alternately variable <= value, in the case where the goal is lower instead of higher)
In fact, if you do want it to be strictly equal to a value, you still don't want to do == if it's floating point! Because that will, in most cases, come out false, even with two numbers that should be the same, due to tolerances and other technical reasons. (You can do a strict equality only with pure integer types)
Let's say you wanted to test if a number was equal to 5, but it's floating point. if(variable == 5) would most likely come out false. Instead the correct way to do this would be if(variable >= 4.999999 && variable <= 5.000001) or whatever your tolerances. You have to take imprecision of the floating point hardware and implementation into account or you'll get it wrong. This is the case on all hardware and in all programming languages that have a floating point type, whether typed or not.
And then, most importantly, actually *check* that your program behaves as it should. Test before you upload. Don't just assume you got it right. You're still not adequately testing. You're not new to putting games on Newgrounds, but yet you're still making these same math mistakes which you should have learned from ages ago. This is just very basic stuff. It's not hard to get right. You don't need any advanced math or anything of the sort. It's all very basic addition, subtraction, and comparison.
I know you can do it. You just need to take more time with it. Not rush to submit things. And play through your games a few times to make sure they work correctly, *before* submitting them.
secret medals = prestige ? :X
applessmillion responds:
Secret medals = getting real high numbers for each upgrade ;)
Its a fun way to pass time, but a complaint I would have is on the "one time upgrades," usually in these games they exist and once you buy them you keep them after prestiging or resetting, but here you have to buy them over again, also it would be nice if more were added or if doing prestige added better stats rather than the small increase they do, otherwise the game is just a good way to pass any extra time.
This is just.. such a bad incremental.
Such a bad UI. So little actual meaningful content. Nothing changes. Just the numbers. Nothing changes mechanically. The cut-away upgrades menus is so unnecessary. The way you weren't able to get music working in the game window without an embedded player that turns off when you go to a different menu.
I could go on and on.. but it's just not worth it. Clean up your design and learn a bit more about what makes an incremental fun (hint: unfolding)
applessmillion responds:
I will admit, it has been a few years since I've been in the incremental game territory and much has changed. Games like mine from 2015 aren't really that great in the landscape of what incremental games are now. UI is a mess, but it's the best I could come up with after testing cross-platform, multi-resolution displays.
Thanks for the feedback, and I'll keep some of your points in mind if I end up creating another incremental game in the future!