PHP crap question

[Toxxicc]

Well, I'm making a directory script based off tidbits from here and there,
but I keep running into something I can't figure out...
I have the page read a directory based on what the url is,

e.g. "directory.php?dir=index"

the script I made can be found here.

It's messy, yes, but I'm not worried about how it looks, just how it works.

Anyway, the problem is that when add "?dir=xxx" it works perfectly, but if I don't put it then it results in an error (click.)

What is causing this error, and how could I fix it?

[thecoshman]

not looking at your script, but i bet that it has no way of coping with out a variable set. either tell it a efult variable, on only have it run if the variable is set.

you can check if a varable is set buy going:

if (isset($var)){
true
} else {
flase
}

[JeremysFilms]

Well you'd probably want to test if the dir variable is feeded into the URL and if not just redirect to the main page, along with if it's set to an unfound file.

So you need to test if the variable is set in the URL by doing something like:
if(!isset($_GET['dir'])){
//redirect stuff
}

Then you need to test if the file is found.. so use something like:
if(!file_exists($dir)){
//redirect stuff
}else{
//continue
}

The continue comment area is for the rest of the stuff, like this should go before it tries to open the directory.

[elbekko]

Well, the simplest solution for this kind of thing is to put this line on top:

$readdir = isset($_GET['dir']) ? $_GET["dir"] : 'index';

Basically, it'll check if the dir is specified, and uses that, but uses index if dir isn't specified.

[Toxxicc]

At 11/19/06 03:29 PM, elbekko wrote: Well, the simplest solution for this kind of thing is to put this line on top:

$readdir = isset($_GET['dir']) ? $_GET["dir"] : 'index';

Basically, it'll check if the dir is specified, and uses that, but uses index if dir isn't specified.

Thanks, works like a charm.