Php: Languages (system) (basic)

[Craige]

Everyone note: in his sample index file, he should have used double quotes on the seccond include. It will not work without the double quotes (unless you change the code a little).

Other than that, Neill, it was a pretty decent tutorial. I would havd thought the topic to be self explanitory, but then for some people...

One thing though was your line spacing. I really think it should have been every line, though this did seem pretty on the eyes.

[henke37]

A few thinngs:
1 It would be a lot better if you made it read the header specifieing what langs the client can use.
2 You better make sure nothing nasty slips into the $choice.
3 You shouldn't polute the variable space, use an array.

[elbekko]

At 8/12/06 07:21 AM, henke37 wrote: 3 You shouldn't polute the variable space, use an array.

Indeed.
Just doing this:

<?php
include 'lang/'.$user['lang'].'/lang.php';
echo $site_lang['Hello'];
?>

And lang/*/lang.php could contain this:
<?php
$site_lang = array(
"hello" => "hi and welcome"
);
?>

And easily expandable... I'm using this system right now =)

[henke37]

All major webbrowsers sends a request header specifying what langs the user wants the info in.
Ever seen a error message in your native lang from a foregin server? That is that header.
But your design allows the user to chose their lang, but the header is a good default.

About the dropdown, nothing stops a hacker from makeing their own form.

[henke37]

I think you are failing to see how serious it is if a hacker can pass a string to include.